[mythtv-commits] Ticket #7049: Bookmark added at end of recording after automatically marked as watched

MythTV mythtv at cvs.mythtv.org
Mon Oct 5 22:01:20 UTC 2009


#7049: Bookmark added at end of recording after automatically marked as watched
-------------------------------------+--------------------------------------
 Reporter:  lynchmv at gmail.com        |        Owner:  mdean  
     Type:  defect                   |       Status:  closed 
 Priority:  minor                    |    Milestone:  unknown
Component:  MythTV - Video Playback  |      Version:  head   
 Severity:  medium                   |   Resolution:  fixed  
  Mlocked:  0                        |  
-------------------------------------+--------------------------------------
Changes (by mdean):

  * status:  accepted => closed
  * resolution:  => fixed


Comment:

 (In [22259]) Fixes #7049.  Checks to see if exiting playback at the end of
 the recording before setting the bookmark.  For users with "Prompt at end
 of recording," this change just prevents a bookmark from being set at the
 point where the prompt is displayed (and, since the end-of-recording
 prompt does not allow setting bookmarks, the change just makes Myth do the
 right thing).  For users with the end-of-recording prompt disabled, this
 effectively prevents the user from setting a bookmark within the last 2s
 of the recording through the "Action on playback exit" (either "Save
 position and exit" or one of the "Prompt" values).

 The fast-fingered (or really unlucky) user with end-of-recording prompts
 disabled can still set a bookmark within 2s of the end of recording, or
 any user can set a bookmark very close to the point where playback will
 exit by using the SELECT key.  Doing so may make it hard for the user to
 react in time when resuming playback at the bookmark, but those users can
 simply restart playback from the beginning (INFO|Play from...|Play from
 beginning) and clear the bookmark or set it at a more appropriate place.

 I may change the approach being used to fix this issue after 0.22 is
 released wi
 th some patches I have, but those patches change more than I want to
 change during a feature freeze.  Alternatively, the root issue (user is
 unable to react before playback exits if the bookmark is too close to the
 end of recording) may be fixed as a result of changes to end-of-recording
 handling related to #6974.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7049#comment:4>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list