[mythtv-commits] Ticket #7560: jamu.py always exits with error 1

[MythTV]

#7560: jamu.py always exits with error 1
-----------------------------------+----------------------------------------
 Reporter:  james@…                |       Owner:  awithers
     Type:  patch                  |      Status:  new     
 Priority:  minor                  |   Milestone:  unknown 
Component:  Plugin - MythVideo     |     Version:  0.22    
 Severity:  medium                 |     Mlocked:  0       
-----------------------------------+----------------------------------------
 As of r22189 of /branches/release-0-22-fixes, the jamu.py script included
 with MythVideo exits with either sys.exit(True) or sys.exit(False),
 presumably intended to exit normally or in error, respectively.

 However, according to the Python spec at
 http://docs.python.org/library/sys.html#sys.exit, any non-integer non-None
 object passed to sys.exit() will result in an error code 1.

 This means that the script will always terminate returning error code 1,
 even when it should be completing successfully. At least by default in
 Ubuntu, this script is run hourly, which creates a lot of spam to root
 about a failing script.

 Please find attached a patch for jamu.py that changes all sys.exit() calls
 to use integer arguments.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7560>
MythTV <http://www.mythtv.org/>
MythTV