[mythtv-commits] Ticket #7538: Mythweb video streaming bug incorrect fullscreen aspect
MythTV
mythtv at cvs.mythtv.org
Tue Nov 10 22:03:16 UTC 2009
#7538: Mythweb video streaming bug incorrect fullscreen aspect
---------------------------------+------------------------------------------
Reporter: scottadmi@… | Owner: kormoc
Type: defect | Status: new
Priority: minor | Milestone: 0.22
Component: Plugin - MythWeb | Version: 0.22
Severity: medium | Mlocked: 0
---------------------------------+------------------------------------------
First, at line 52 of mythweb/modules/stream/stream.flv, the code reads:
{{{
$width = round_even(width);
}}}
This will always produce a zero result because it is missing the $ for the
variable yielding a potentially wrong aspect, and should be:
{{{
$width = round_even($width);
}}}
Second, the height of the flowplayer controls are 25 pixels not 20 as
written, so 25 should be used when determining the flv_h value used for
the block. In the default template (modules/tv/tmpl/default/detail.php -
line 30). It should be corrected as such:
{{{
$flv_h = intVal($flv_w / $program->getAspect()) + 25; // +25px for the
playback controls
}}}
Further, at full screen, the video streaming simply fills whatever screen
resolution it is being viewed at, instead of filling it at the correct
aspect. This can be corrected very simply by adding the following into the
flowplayer script for the video (again in detail.php)
{{{
scaling: 'fit',
}}}
which will yield:
{{{
// Then we have the video
{
url: "<?php echo video_url($program, 'flv');
?>",
duration: <?php echo $program->length ?>,
autoPlay: false,
scaling: 'fit',
// Would be nice to auto-buffer, but we don't
want to
// waste bandwidth and CPU on the remote
machine.
autoBuffering: false
}
]}
}}}
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7538>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list