[mythtv-commits] Ticket #7494: Program Guide option "Allow channel jumping in guide" is always true

[MythTV]

#7494: Program Guide option "Allow channel jumping in guide" is always true
----------------------------------------------------+-----------------------
 Reporter:  Steven Ellis <support@…>                |       Owner:  ijr    
     Type:  defect                                  |      Status:  new    
 Priority:  minor                                   |   Milestone:  unknown
Component:  MythTV - General                        |     Version:  0.22rc1
 Severity:  medium                                  |     Mlocked:  0      
----------------------------------------------------+-----------------------

Comment(by Steven Ellis <steven@…>):

 I think the code relating to this is GuideGrid::keyPressEvent in
 guidegrid.cpp

 I don't understand the logic of this particular section
 {{{
     // We want to handle jump to channel before everything else
     // The reason is because the number keys could be mapped to
     // other things. If this is the case, then the jump to channel
     // will not work correctly.
     {
         QMutexLocker locker(&m_jumpToChannelLock);

         if (!m_jumpToChannel || m_jumpToChannelEnabled)
         {
             bool isNum;
             event->text().toInt(&isNum);
             if (isNum && !m_jumpToChannel)
             {
                 // see if we can find a matching channel before creating
 the JumpToChannel otherwise
                 // JumpToChannel will delete itself in the ctor leading to
 a segfault
                 int i = FindChannel(0, event->text(), false);
                 if (i >= 0)
                 {
                     m_jumpToChannel = new JumpToChannel(this,
 event->text(),
 m_currentStartChannel,
                                                         m_currentRow,
 m_channelCount);
                     updateJumpToChannel();
                 }

                 handled = true;
             }
         }

         if (m_jumpToChannel && !handled)
             handled = m_jumpToChannel->ProcessEntry(actions, event);
     }
 }}}

 It appears that m_jumpToChannel will be NULL so numeric key presses will
 cause a jump to channel even if m_jumpToChannelEnabled=FALSE.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7494#comment:1>
MythTV <http://www.mythtv.org/>
MythTV