[mythtv-commits] Ticket #6333: Fanart directory setting inconsistent

[MythTV]

#6333: Fanart directory setting inconsistent
------------------------------------+---------------------------------------
 Reporter:  paul [at] planar.id.au  |       Owner:  awithers
     Type:  defect                  |      Status:  new     
 Priority:  minor                   |   Milestone:  unknown 
Component:  Plugin - MythVideo      |     Version:  unknown 
 Severity:  medium                  |     Mlocked:  0       
------------------------------------+---------------------------------------
 The fanart directory setting in the setting table that is saved by the
 settings screen is "mythvideo.fanartDir", the setting that is read by
 videodlg.cpp is "VideoFanartDir".  So far as I can tell the more standard
 is that written by the settings screen, so this patch changes videodlg.cpp
 to use that.

 I also noticed that "VideoArtworkDir" is used - I've changed this also to
 "mythvideo.screenshotDir" as that appears in the settings table - but it
 isn't clear to me that VideoArtworkDir is screenshot, as opposed to
 banner.

 In looking to work out what VideoArtworkDir might be I noticed that in
 videodlg.cpp, m_artdir and m_fandir have quite different usage - I kind of
 assumed they would be similar.  I can't be sure without knowing the code
 better, but it looks to me like the settings screen recognises:
  - banners
  - fanart
  - screenshots
  - plus the things it already recognised

 videodlg.cpp seems to recognise fanart and videoartwork.  So they look to
 be out of synch with each other.

 Anyway, I patched what I could, and leave the rest for someone who knows
 the code better.

 PS: Thanks heaps for the fanart patches - I'm excited by what they might
 mean for themes, and it is great to see this area being worked on so
 actively.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6333>
MythTV <http://www.mythtv.org/>
MythTV