[mythtv-commits] Ticket #6597: win32 patches for backend, HDHR, datadirect, transcode

[MythTV]

#6597: win32 patches for backend, HDHR, datadirect, transcode
----------------------------------------+-----------------------------------
 Reporter:  Jeff Lu <jll544 at yahoo.com>  |        Owner:  ijr    
     Type:  patch                       |       Status:  new    
 Priority:  minor                       |    Milestone:  unknown
Component:  MythTV - General            |      Version:  head   
 Severity:  medium                      |   Resolution:         
  Mlocked:  0                           |  
----------------------------------------+-----------------------------------

Comment(by davidbuzz at gmail.com):

 HI Jeff, visual review of these looks good!.

 some possible improvements might include:

 backend patch relies on the %PATH% being set correctly.  If a
 unix/mingw/msys/cygwin find.exe command is in the path before the default
 windows one, then this breaks the backend code supplied.  may I suggest
 full path definition of %SystemRoot$/System32/find.exe  be used.

 From memory, I thin a lot of win32 code in mythtv uses #ifdef _WIN32
 instead of #ifdef USING_MINGW.  No biggie either way, I'm just thinking of
 standardising on one of them

 A lot of single Vs double quoting issues - unix = ' windows = \"
 Perhaps using a QString.replace finction to convert single quote to
 backquoted double quotes on-the-fly on windows only might be more future-
 proof.?
   str.replace(QString("'"), QString("\\""));   (or similar )

 A bunch of functions in NuppelVideoRecorder.cpp are basically a no-op
 under mingw.
 Rather than #ifndef USING_MINGW inside all these functions, maybe you
 could supply these MINGW versions as a separate implementation, or move
 the null-op-mingw-versions to the end of the file?  not sure.hhmmmm.

 like I said though, the rest of it looks good from here ( untested).
 Buzz.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6597#comment:1>
MythTV <http://www.mythtv.org/>
MythTV