[mythtv-commits] Ticket #6748: BluRay Subtitle Support
MythTV
mythtv at cvs.mythtv.org
Sat Jul 25 08:10:13 UTC 2009
#6748: BluRay Subtitle Support
-----------------------------------------+----------------------------------
Reporter: Stephen <stev391 at email.com> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: unknown
Severity: medium | Resolution:
Mlocked: 0 |
-----------------------------------------+----------------------------------
Comment(by Stephen <stev391 at email.com>):
Just added a version of the patch that makes the subtitles appear! They
are delayed from when they are supposed to be displayed, but late is
better then none.
Since last patch a small tidy up of the code (in response to FFmpeg review
comments) and also a small change to the scaling code in MythTV relating
to subtitles. Two issues were noted in regards to scaling:
1) The code currently determines a scale factor against a 720x576 screen
size, this factor was then used to scale the x,y,w & h variables. However
the scaling factor was performing the opposite to intended (in this case
it was enlarging the subtitles as they were out of the screen size
originally), to fix this multiplication was replaced with division.
2) Once the above was fixed it was evident that this scaling was not
needed (subtitles were small and closer to top left corner then they were
supposed to be). So I have hard coded the scaling factor to 1.0 at the
moment, until I can determine the correct way of achieving the desired
outcome.
So enjoy subtitles!
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6748#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list