[mythtv-commits] Ticket #6725: segmentation fault in mythbackend

[MythTV]

#6725: segmentation fault in mythbackend
-------------------------------------------+--------------------------------
 Reporter:  Simon Kenyon <simon at koala.ie>  |        Owner:  danielk
     Type:  defect                         |       Status:  new    
 Priority:  minor                          |    Milestone:  0.22   
Component:  MythTV - DVB/ATSC              |      Version:  head   
 Severity:  medium                         |   Resolution:         
  Mlocked:  0                              |  
-------------------------------------------+--------------------------------
Changes (by stuartm):

  * status:  infoneeded_new => new
  * milestone:  unknown => 0.22


Comment:

 Following patch should prevent the segfault, though I'm not sure whether
 'state' should default to false or true if we fail to discover it's true
 state.

 {{{
 Index: mythtv/programs/mythbackend/playbacksock.cpp
 ===================================================================
 --- mythtv/programs/mythbackend/playbacksock.cpp        (revision 20919)
 +++ mythtv/programs/mythbackend/playbacksock.cpp        (working copy)
 @@ -289,8 +289,14 @@
                  " gave us no response.");
      }

 +    bool state = false;
 +
 +    if (!strlist.isEmpty())
 +    {
      QStringList::const_iterator it = strlist.begin();
 -    bool state = (*it).toInt();
 +        state = (*it).toInt();
 +    }
 +
      if (busy_input)
      {
          it++;
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6725#comment:8>
MythTV <http://www.mythtv.org/>
MythTV