[mythtv-commits] Ticket #6193: Screensaver seems to be completely broken now

[MythTV]

#6193: Screensaver seems to be completely broken now
--------------------------------+-------------------------------------------
 Reporter:  mythtv at meric.id.au  |        Owner:  ijr           
     Type:  defect              |       Status:  infoneeded_new
 Priority:  minor               |    Milestone:  0.22          
Component:  MythTV - General    |      Version:  head          
 Severity:  medium              |   Resolution:                
  Mlocked:  0                   |  
--------------------------------+-------------------------------------------

Comment(by mythtv at meric.id.au):

 Ah... found it!

 In screensaver-x11.cpp the initial state of DPMS is stored in
 m_dpmsenabled, which is referred to by IsDPMSEnabled().  DisableDPMS()
 correctly uses IsDPMSEnabled() to determine whether the screen saver is
 disabled or not and then sets the global m_dpmsdeactivated (but only if it
 wasn't already disabled).  However, RestoreDPMS() only uses the global
 m_dpmsdeactivated to determine the current state, which is never set in
 the case where DPMS was inactive at startup.

 Presumably all of this is to cater for cases where DPMS is not actually
 supported on the display, so changing the tests in DisableDPMS() or
 RestoreDPMS() may cause problems.  Attached is a patch which simply re-
 enables DPMS if it is found to be disabled at startup.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6193#comment:5>
MythTV <http://www.mythtv.org/>
MythTV