[mythtv-commits] Ticket #5922: fix finnish rerun detection

[MythTV]

#5922: fix finnish rerun detection
-------------------------+--------------------------------------------------
 Reporter:  ikke at iki.fi  |        Owner:  stuarta   
     Type:  patch        |       Status:  new       
 Priority:  minor        |    Milestone:  0.22      
Component:  eit          |      Version:  0.21-fixes
 Severity:  medium       |   Resolution:            
  Mlocked:  0            |  
-------------------------+--------------------------------------------------
Changes (by janne):

  * status:  infoneeded_new => new


Comment:

 Replying to [comment:3 stuarta]:
 > The bulk of this patch is fine. However i'm not happy
 > with putting a fixup in that is only keyed off NetworkID=0.
 >
 > This is known to be used by numerous buggy providers,

 it is only used by buggy providers, the DVB standard doesn't allow that
 value.

 >    // DVB-C Elisa Finland
 >    fix[  0U << 16] = EITFixUp::kFixFI;
 >
 > to include transportid and serviceid.

 I'm not sure if it's a good idea to have one fixup for every channel on
 that network. It doesn't ensure unique id's. I assume that it's common for
 buggy providers that the transport and service ids start at 0 too.

 If the other ids look rather random it is still a bad idea since we have
 to udate the fixups for every channel change on the network.

 I would say we can't unfortunately do fixups on broken networks.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5922#comment:4>
MythTV <http://www.mythtv.org/>
MythTV