[mythtv-commits] Ticket #7804: mpegts demuxer sets codec_tag incorrectly

[MythTV]

#7804: mpegts demuxer sets codec_tag incorrectly
-----------------------------------+----------------------------------------
 Reporter:  thfisher@…             |       Owner:  ijr    
     Type:  defect                 |      Status:  new    
 Priority:  minor                  |   Milestone:  unknown
Component:  MythTV - General       |     Version:  head   
 Severity:  low                    |     Mlocked:  0      
-----------------------------------+----------------------------------------
 Changeset 20971 introduced a minor bug in the setting of
 codec->codec_type.

 In the function
 {{{
 new_pes_av_stream()
 }}}
 , the line

 {{{
     st->codec->codec_tag = pes->stream_type;
 }}}

 is setting the codec_tag to the ISO stream id instead of the appropriate
 tag.  (eg. 0x1b for H264 instead of 'H''2''6''4').

 While this doesn't appear to break anything in trunk now, it does break
 the patches for anyone using CoreAVC, and may break something in the
 future.

 Commenting out the line or applying the attached patch resolve the
 immediate problem with the CoreAVC patch however there may be a better way
 to handle this.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7804>
MythTV <http://www.mythtv.org/>
MythTV