[mythtv-commits] Ticket #7778: Up and down scrolling directions are reversed in MythGallery

[MythTV]

#7778: Up and down scrolling directions are reversed in MythGallery
----------------------------------------------+-----------------------------
 Reporter:  Clayton Smith <argilo@…>          |       Owner:  ijr    
     Type:  patch                             |      Status:  new    
 Priority:  minor                             |   Milestone:  unknown
Component:  Plugin - MythGallery              |     Version:  head   
 Severity:  medium                            |     Mlocked:  0      
----------------------------------------------+-----------------------------

Comment(by Clayton Smith <argilo@…>):

 Replying to [comment:1 mdean]:
 > The scrolling seems to work as designed (and as originally implemented
 in [1735] ).  The bindings used are "SCROLLUP" (with help text, "Scroll
 image up," and default binding of 2) and "SCROLLDOWN" (with help text,
 "Scroll image down," and default binding of 8).  When you use the SCROLLUP
 binding (2), the /image/ is moved up while the viewport remains fixed, so
 you see a portion of the image lower than the portion you were seeing.
 Similarly, when you use the SCROLLDOWN binding (8), the image is moved
 down while the viewport remains fixed, so you see a portion of the image
 higher than the portion you were seeing.

 If that's the case, then why doesn't SCROLLLEFT move the image left and
 SCROLLRight move the image right?  They both move the viewport, as one
 would expect.

 > My preference, however, would be to completely get rid of the SCROLLUP,
 SCROLLDOWN, SCROLLLEFT, and SCROLLRIGHT bindings used /only/ by
 MythGallery and change the plugin to use the global UP, DOWN, LEFT, and
 RIGHT bindings used everywhere else in Myth--where UP would scroll the
 viewport up (so you see a higher portion of the picture) and DOWN would
 scroll the viewport down (so you see a lower portion of the picture).
 Using the global directional keybindings works well for *both* keyboards
 and remotes (and would work fine for a remote without arrows if the user
 overrides the global bindings for the directional keys in the Gallery
 context to use numbers as now).  I have a patch in the works that would
 allow users to add a new keybinding to a context using MythControls--
 effectively allowing users to override bindings in lower contexts with the
 GUI keybinding editor instead of direct DB editing.

 UP/LEFT are already used to move to the previous image, and DOWN/RIGHT
 move to the next image.  Are you proposing changing the behaviour so that
 these keys behave differently during zooming, and not using the numeric
 keypad any more for scrolling?

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7778#comment:2>
MythTV <http://www.mythtv.org/>
MythTV