[mythtv-commits] Ticket #7777: patch to fix network control 'play program chanid time' command

[MythTV]

#7777: patch to fix network control 'play program chanid time' command
-------------------------------------------------+--------------------------
 Reporter:  Randy Rossi <randy.rossi@…>          |       Owner:  ijr 
     Type:  patch                                |      Status:  new 
 Priority:  minor                                |   Milestone:  0.22
Component:  MythTV - General                     |     Version:  head
 Severity:  medium                               |     Mlocked:  0   
-------------------------------------------------+--------------------------
 network control waited for playback box screen before trying to play
 requested program and then tried to change the selected item in the
 recordings list to the found program, then play using playSelected()
 method.

 There were three problems with this.

 1st was a race condition: just because the playbackbox screen is visible,
 that doesn't mean it's done populating the recordings list ui items.  So
 the network control handler method was searching within an empty list.

 2nd problem was that the comparison to the program info record found was
 failing when it tried to set the current selected item, even if the
 recordings list was populated since it points to a different program info
 structure anyway (qvariants were different so set selected item would
 fail)

 3rd problem was that the user might have a group filter that doesn't even
 include the item being searched for so we would have to switch to all
 programs filter before searching.

 Solution was to have the network control handler method in playbackbox.cpp
 just use the programinfo structure it found from the database query
 instead of trying to simulate a user selecting it from the list.

 Patches for both 0.22 and trunk included.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7777>
MythTV <http://www.mythtv.org/>
MythTV