[mythtv-commits] Ticket #6516: Mythfilldatabase times out when rescheduling

[MythTV]

#6516: Mythfilldatabase times out when rescheduling
------------------------------------------+---------------------------------
 Reporter:  Joel <mythtv at ebel.mybox.org>  |        Owner:  danielk
     Type:  defect                        |       Status:  closed 
 Priority:  blocker                       |    Milestone:  0.22   
Component:  MythTV - General              |      Version:  head   
 Severity:  medium                        |   Resolution:  fixed  
  Mlocked:  0                             |  
------------------------------------------+---------------------------------
Changes (by danielk):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 (In [21608]) Fixes #6516. This is the last of the mythsocket fixes sitting
 in my tree...

 This speeds up worst case mythsocket handling. The worst case speedup is
 entirely do to with the locking*, but we also use QWaitConditions for some
 special cases, such as when starting up the socket handling loop and when
 all sockets are closed, or when anonymous file descriptor pipes are not
 available. This also adds some timing debug code at the -v socket,extra
 level, but I left out most of the ones I used when optimising this code,
 the remaning ones should be sufficient to locate any significant
 regressions
 in the future.

 This also gets rid of the special case stuff for MS Windows for which
 there
 may need to be some additional header changes, but the code itself does
 work
 when you inlcude compat.h. But compat.h shouldn't be included in any
 plugin
 exported header files so I've left the header problem for someone with an
 MS Windows system to work out (aside from fixing the select header problem
 previously reported).

 FYI [21589] provides a larger worst-case speedup, but in my testing both
 changesets are needed to completely avoid timeouts.

 * The main locking problem was just when we deleted sockets, this was
   treated as a rare occurance and we dropped and relocked the
 m_readyread_lock.
   But this would sometimes cause large enough delays to cause timeouts,
   which lead to more deleted sockets, causing more timeouts, etc.
   We now put these in a list and handle them later on when we've dropped
   the m_readyread_lock anyway for ready read data handling.
 ** A secondary locking problem had to do with our isLocked() handling,
    this was really a Qt4 port problem, the code was rewritten to work with
    Qt4 which dropped QMutex::locked(), but the new code was not very
    efficient.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6516#comment:13>
MythTV <http://www.mythtv.org/>
MythTV