[mythtv-commits] Ticket #6795: [win32] mythmusic compilation fails at linker stage

[MythTV]

#6795: [win32] mythmusic compilation fails at linker stage
----------------------------------------------------+-----------------------
 Reporter:  Jonathan Martens <jonathan at snetram.nl>  |       Owner:  nigel
     Type:  defect                                  |      Status:  new  
 Priority:  minor                                   |   Milestone:  0.22 
Component:  Ports - Windows                         |     Version:  head 
 Severity:  medium                                  |     Mlocked:  0    
----------------------------------------------------+-----------------------
 It seems the link stage of compiling mythmusic fails because libflac on
 windows is compiled against winsock (), as this is not in the LIBS setting
 of mytmusic it fails to compile with the following error:

 u:/Msys/1.0/lib/libFLAC.a(bitwriter.o): In function
 `FLAC__bitwriter_get_buffer'
 :
 u:/sources/flac-1.2.1/src/libFLAC/bitwriter.c:286: undefined reference to
 `ntohl
 @4'
 u:/Msys/1.0/lib/libFLAC.a(bitwriter.o): In function
 `FLAC__bitwriter_write_rice_
 signed_block':
 u:/sources/flac-1.2.1/src/libFLAC/bitwriter.c:611: undefined reference to
 `ntohl
 @4'
 u:/sources/flac-1.2.1/src/libFLAC/bitwriter.c:645: undefined reference to
 `ntohl
 @4'
 u:/Msys/1.0/lib/libFLAC.a(bitwriter.o): In function
 `FLAC__bitwriter_write_raw_u
 int32':
 u:/sources/flac-1.2.1/src/libFLAC/bitwriter.c:367: undefined reference to
 `ntohl
 @4'
 u:/sources/flac-1.2.1/src/libFLAC/bitwriter.c:373: undefined reference to
 `ntohl
 @4'
 u:/Msys/1.0/lib/libFLAC.a(bitwriter.o):u:/sources/flac-1.2.1/src/libFLAC/bitwrit
 er.c:321: more undefined references to `ntohl at 4' follow
 collect2: ld returned 1 exit status
 make[1]: *** [libmythmusic.dll] Error 1
 make[1]: Leaving directory `/u/mythtv/mythplugins/mythmusic/mythmusic'
 make: *** [sub-mythmusic-make_default] Error 2

 Making a minor tweak to the LIBS line in the Makefile
 (mythplugins/mythmusic/myshmusic/Makefile) fixes it. Unfortunately I do
 not know how to make the modifications to the makefile macros to
 incorporate linking winsock, but the desired result, but I think there are
 others who know how to do this. The desired change in the eventual
 Makefile is shown in the attached unified diff file.

 If I make this modification manually the errors are gone after rerunning
 make.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6795>
MythTV <http://www.mythtv.org/>
MythTV