[mythtv-commits] mythtv commit: r20311 by gigem

[mythtv at cvs.mythtv.org]

      Author: gigem
        Date: 2009-04-06 19:11:38 +0000 (Mon, 06 Apr 2009)
New Revision: 20311
   Changeset: http://cvs.mythtv.org/trac/changeset/20311

Modified:

   trunk/mythtv/libs/libmythtv/tv_play.cpp
   trunk/mythtv/libs/libmythtv/tv_rec.cpp

Log:

Changed TVRec to estimate the recording length when sending a
DONE_RECORDING message based on the start and stop times instead of
using the total number of frames and a potentially bogus frame rate.
Digital recorders do not currently try to determine nor have other
access to the actual frame rate, so the resulting estimate can be
wildly inaccurate.  This is the cause of the bug where progressive
recordings that end while they are being watched get incorrectly
reported as being twice as long as they actually are.  This change
technically fixes that bug.

Unfortunately, the new estimate calculated by TVRec can still be off
by several seconds due to differences in recorder startup and teardown
times.  To mitigate that problem until a more accurate length can be
calculated, the total number of frames is now also reported in the
DONE_RECORDING message.  The TV class does have access to the actual
frame rate, so it can and now does recalculate a more accurate
estimate of the length before updating NVP.