[mythtv-commits] Ticket #5820: Improvements to Musicbrainz compilation album detection
MythTV
mythtv at cvs.mythtv.org
Mon Oct 13 20:26:58 UTC 2008
#5820: Improvements to Musicbrainz compilation album detection
-------------------------------------+--------------------------------------
Reporter: drdaz7 at gmail dot com | Owner: ijr
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: mythmusic | Version: 0.21-fixes
Severity: medium | Mlocked: 0
-------------------------------------+--------------------------------------
I recently began (re)tagging my music using Musicbrainz Picard. It's a
fantastic piece of software. I ran into some issues with compilation
albums in mythmusic, however as each track on the album was being placed
separately under the track artist name instead of the album artist name.
I did a little research and found that:
a) A number of others have the same problem
b) There is code in mythmusic which is supposed to remedy this (ticket
#3697)
I found that the code in mythmusic checks for the special Musicbrainz
Various Artists album artist ID, and only then will it class the album as
a compilation. In addition, it checks the 'TPE4' tag in mp3 files for the
compilation artist.
This leaves us the following issues:
a) When a compilation album is attributed to an album artist other than
'Various Artists' in the Musicbrainz database, the files will not be
tagged such that mythmusic recognizes them as compilations.
b) In mp3 files, mythmusic is checking TPE4 for album artist info, when
Picard is writing that info in TPE2 (see
http://wiki.musicbrainz.org/PicardTagMapping for details on where Picard
writes its information).
I have written a patch against 0.21-fixes which helps the situation (for
me at least) by:
a) Checking the 'release type' flag for the keywords 'compilation' or
'soundtrack' as additional hints that an album is a compilation.
b) Checking TPE2 in mp3 files instead of TPE4 for album artist info.
I have been using these alterations myself for a number of weeks now, and
it has solved compilation album issues for me for mp3 and ogg files. All
of my music is in one of these formats, so I have not needed to change, or
been able to test, other formats.
I am not a C++ coder, so there may well be prettier / better ways to do
this, but I tried to maintain a similar style to what was there.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/5820>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list