[mythtv-commits] Ticket #5910: Fix "Automatically mark a recording as watched" to work with prompts enabled

[MythTV]

#5910: Fix "Automatically mark a recording as watched" to work with prompts
enabled
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |       Owner:  ijr       
     Type:  patch                             |      Status:  new       
 Priority:  minor                             |   Milestone:  unknown   
Component:  mythtv                            |     Version:  0.21-fixes
 Severity:  medium                            |     Mlocked:  0         
----------------------------------------------+-----------------------------
 The "Automatically mark a recording as watched" setting only works when
 prompts (either "Action on playback exit" or "Prompt at end of recording",
 depending on how you exit playback) are disabled.  There used to be an
 option in the exit prompt dialog, "Mark as watched and go to the menu,"
 but the option was removed from the exit prompt in [11253].

 Because the prompt had an option to mark a show as watched, the code was
 written so that it did not automatically mark shows as watched if prompts
 were enabled.  Now that the option no longer exists, it makes sense to
 automatically mark recordings as watched even if prompts are enabled
 (assuming the "Automatically mark a recording as watched" is enabled).  If
 we don't do this, users who enable prompts think the "Automatically mark
 ..." setting isn't working.

 The attached patch fixes the issue with prompts and several other exit
 conditions (including through network control, when using JUMPPREV or
 JUMPPROG).  I tested each exit condition with each setting for the prompts
 and they work (at least, as I would expect).  The approach I took was to
 allow shows to be marked as watched consistently (basically when not
 deleting the show) so the user doesn't have to second-guess whether to
 unmark a show--i.e. if you exit near the end and have the "Automatically
 mark..." setting enabled, it will be marked as watched, so if you want to
 keep the show, unmark it or disable the setting.

 First patch is for 0.21-fixes.  I'm currently converting to/testing with
 trunk.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5910>
MythTV <http://www.mythtv.org/>
MythTV