[mythtv-commits] Ticket #5893: keystroke handling for Lirc too expensive
MythTV
mythtv at cvs.mythtv.org
Sun Nov 9 03:26:41 UTC 2008
#5893: keystroke handling for Lirc too expensive
---------------------------------+------------------------------------------
Reporter: km at mathcs.emory.edu | Owner: stuartm
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: libmythui | Version: unknown
Severity: medium | Resolution:
Mlocked: 0 |
---------------------------------+------------------------------------------
Comment(by sphery <mtdean at thirdcontact.com>):
The attached patch, mythtv-5893-throttle_screensaver_deactivate-2.patch ,
fixes the missing check for whether GNOME screensaver is active and also
throttles screensaver deactivation by only running the command at most
once every 31 seconds (i.e. if it's been more than 30 seconds since the
last time we ran the command to deactivate the screensaver).
I chose 30 seconds thinking it was a reasonable value as people are
unlikely to ever set their screensaver to activate due to 30 seconds or
less of idle time. In truth, I can't imagine anyone using an idle timeout
of less than 1 minute, so increasing the value to 50 (or even 58?) seconds
may make sense.
This throttling does mean that not every button press will reset the clock
for the screensaver timeout, so from that perspective, using a value of 28
may make sense for an expected minimum screensaver timeout of 1 minute.
In practical terms, throttling deactivation with a value of 30 for the
time comparison simply means that the user may experience a screensaver
timeout after a LIRC button press/joystick event that's up to 31 seconds
shorter than expected--which seems reasonable.
As far as the "option to disable screensaver checking" goes, the patch
allows this by only running the deactivate command if either xscreensaver
or gnome-screensaver is actually running. Therefore, after the patch is
applied, when not running xscreensaver and gnome-screensaver, Myth will
not attempt to deactivate the screensaver.
The -2 version of the patch is the same as the first one I uploaded, but
also adds a check for IsScreenSaverRunning() before doing the date math so
it's only performed if a screensaver is running.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/5893#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list