[mythtv-commits] Ticket #5286: Fix initial database creation

MythTV mythtv at cvs.mythtv.org
Sat May 3 21:53:19 UTC 2008


#5286: Fix initial database creation
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |        Owner:  ijr    
     Type:  patch                             |       Status:  new    
 Priority:  minor                             |    Milestone:  unknown
Component:  mythtv                            |      Version:  head   
 Severity:  medium                            |   Resolution:         
  Mlocked:  0                                 |  
----------------------------------------------+-----------------------------

Comment(by sphery <mtdean at thirdcontact.com>):

 mythtv-5286-no_backup_for_new_database.patch adds a new function,
 DBUtil::IsNewDatabase() and moves the check for whether to do a backup to
 DBUtil::DoBackup() .  The current implementation of IsNewBackup() is not
 designed to be called frequently, but it would be possible to make it fast
 by performing a full test only on the first call and remembering the
 result, then resetting the result (to false) if InitializeDatabase()
 succeeds.  This approach may be more appropriate than the upcoming patch
 to change all 'if (dbver == "")' checks to 'if (dbver.isEmpty() || dbver
 == "0")' checks.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5286#comment:1>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list