[mythtv-commits] mythtv commit: r16434 - in branches/release-0-21-fixes/mythtv by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2008-03-08 00:07:31 +0000 (Sat, 08 Mar 2008)
New Revision: 16434
   Changeset: http://cvs.mythtv.org/trac/changeset/16434

Modified:

   branches/release-0-21-fixes/mythtv/libs/libmythtv/DVDRingBuffer.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/NuppelVideoPlayer.h
   branches/release-0-21-fixes/mythtv/libs/libmythtv/avformatdecoder.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_d3d.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_directfb.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_dx.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_ivtv.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_null.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_quartz.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videoout_xv.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videooutbase.cpp
   branches/release-0-21-fixes/mythtv/libs/libmythtv/videooutbase.h
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/BlankFrameDetector.cpp
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/ClassicCommDetector.cpp
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/PGMConverter.cpp
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/SceneChangeDetector.cpp
   branches/release-0-21-fixes/mythtv/programs/mythcommflag/TemplateFinder.cpp
   branches/release-0-21-fixes/mythtv/programs/mythtranscode/transcode.cpp

Log:

Fixes #4567. Fixes rendering of chaff in XVideo renderer when the video buffer size != video frame size.

This is the same as the earlier reverted commit, except that I made sure that the NVP and classes using it don't use the real video frame size unless they know how to handle it. All others use the video buffer size, which is what was being used before this changeset. They are usually the same thing, but when they are not the same you can get rendering artifacts, and if the video frame size is used for buffer allocations you can overwrite memory or if lucky get a segfault.

The earlier reverted commit caused a a portion of the preview videos of videos with a frame size not divisible by 16 in both dimensions to have a green hue over a portion of the image.