[mythtv-commits] Ticket #4838: make sure dvdcss_version always has something in it. Even if it isn't found.

[MythTV]

#4838: make sure dvdcss_version always has something in it. Even if it isn't
found.
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |        Owner:  ijr       
     Type:  defect                           |       Status:  new       
 Priority:  minor                            |    Milestone:  0.22      
Component:  mythtv                           |      Version:  0.21-fixes
 Severity:  low                              |   Resolution:            
  Mlocked:  0                                |  
---------------------------------------------+------------------------------

Comment(by nigel):

 Close, but dvdcss_version is a pointer to a char pointer. I think
 something like this is needed:
 {{{
 % svn diff libs/libmythdvdnav/dvd_input.c
 Index: libs/libmythdvdnav/dvd_input.c
 ===================================================================
 --- libs/libmythdvdnav/dvd_input.c      (revision 16344)
 +++ libs/libmythdvdnav/dvd_input.c      (working copy)
 @@ -343,7 +343,7 @@
      fprintf(stderr, "DVDCSS_VERBOSE %s\n", psz_verbose);
      */
      fprintf(stderr, "libdvdread: Using libdvdcss version %s for DVD
 access\n",
 -           *dvdcss_version);
 +           dvdcss_version ? *dvdcss_version : "unknown");

      /* libdvdcss wrapper functions */
      dvdinput_open  = css_open;
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4838#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV