[mythtv-commits] Ticket #4836: check for null in AvFormatDecoder::ScanDSMCCStreams()'s

MythTV mythtv at cvs.mythtv.org
Tue Mar 4 00:28:29 UTC 2008


#4836: check for null in AvFormatDecoder::ScanDSMCCStreams()'s
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |        Owner:  ijr       
     Type:  defect                           |       Status:  closed    
 Priority:  minor                            |    Milestone:  0.22      
Component:  mythtv                           |      Version:  0.21-fixes
 Severity:  low                              |   Resolution:  invalid   
  Mlocked:  0                                |  
---------------------------------------------+------------------------------
Changes (by nigel):

  * status:  new => closed
  * resolution:  => invalid


Comment:

 Not sure this is needed. OpenFile() sets ic, or returns -1. If it returns,
 !ScanStreams() isn't called, which means !ScanDSMCCStreams() isn't called.
 [[BR]]
 There are many other places where ic is referenced without being checked
 first (''e.g.'' !ScanATSCCaptionStreams(), !ScanTeletextCaption(),
 !DoFastForward(), !SeekReset(), !InitByteContext() ) but I think thee are
 all safe because AVFD doesn't do much if OpenFile() fails.
 [[BR]]
 If you can find any situations where this isn't the case, please re-open.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4836#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list