[mythtv-commits] Ticket #5485: Store the directory a program was created in
MythTV
mythtv at cvs.mythtv.org
Mon Jun 30 22:50:07 UTC 2008
#5485: Store the directory a program was created in
----------------------------------------------------+-----------------------
Reporter: Tony Lill <ajlill at ajlc.waterloo.on.ca> | Owner: ijr
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: mythtv | Version: unknown
Severity: medium | Resolution:
Mlocked: 0 |
----------------------------------------------------+-----------------------
Comment(by Tony Lill <ajlill at ajlc.waterloo.on.ca>):
Because it's easier for external move scripts to update, since they don't
have to grub around in the storage group stuff. Same goes for mythweb, if
it ever wanted to use it.
I don't think it will make the code simpler. At the points where I store
and use the dirname, I'd have to add an extra lookup to go from id to path
or path to id. In fact, in StartedRecording, all I did was turn a local
variable into a class variable. Unfortunately, the code that figures out
where to put a new recording is in an inconvenient place for storing the
id. That was the first place I looked to store the dirname.
I was concerned about db size and bandwidth, but I would expect, in
general, that the dirnames would be relatively short. For example, mine
are less than the size of basename, so the bloat would be fairly small as
a percentage. There are much bigger tables around, so the increase in db
size should be negligable. As for bandwidth, I haven't noticed any
degradation using my xbox frontend, which is usually very sensitive to to
that. Not hard data, but if it was going to kill anything...
As to security, If you can get into the database to change the dirname in
the recorded table, you could also change the dirname in the storage
group. Ditto for a man in the middle attack on the proto. Also, anything
you could do with dirname, you could also do by adding ../ to the start of
basename. I don't think there's anything in myth that strips that sort of
stuff out.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/5485#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list