[mythtv-commits] Ticket #5503: Don't pass negative file descriptors to dup?()

[MythTV]

#5503: Don't pass negative file descriptors to dup?()
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  ijr    
     Type:  defect                           |      Status:  new    
 Priority:  trivial                          |   Milestone:  unknown
Component:  mythtv                           |     Version:  head   
 Severity:  low                              |     Mlocked:  0      
---------------------------------------------+------------------------------
 In libs/libmythui/mythsystem.cpp /dev/null is opened and then dup2'ed. If
 open gave -1, then the check would not be sufficient to stop giving a
 bogus file descriptor to dup, which is bad.

 Since very bad things have to be happening for open() to return a -1 for
 opening /dev/null I am marking this ticket as trivial. But it is a pretty
 easy fix.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5503>
MythTV <http://www.mythtv.org/>
MythTV