[mythtv-commits] Ticket #4661: inputid should be signed or conditional is bogus

MythTV mythtv at cvs.mythtv.org
Wed Feb 13 21:59:12 UTC 2008


#4661: inputid should be signed or conditional is bogus
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  ijr 
     Type:  patch                            |      Status:  new 
 Priority:  minor                            |   Milestone:  0.21
Component:  mythtv                           |     Version:  head
 Severity:  low                              |     Mlocked:  0   
---------------------------------------------+------------------------------
 In dvbchannel.cpp the variable inputid is unsigned. But the conditional
 tests for less then zero. Which will be impossible and the code path will
 never happen. Since the function that is called can return a signed value
 it is better to make inputid signed so the test works.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4661>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list