[mythtv-commits] Ticket #4643: test for empty string
MythTV
mythtv at cvs.mythtv.org
Tue Feb 12 16:57:26 UTC 2008
#4643: test for empty string
---------------------------------------------+------------------------------
Reporter: Erik Hovland <erik at hovland.org> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: 0.21
Component: mythtv | Version: head
Severity: low | Mlocked: 0
---------------------------------------------+------------------------------
In the file avformatdecoder.cpp, in the member function
AvFormatDecoder::ScanStreams there are two tests for the validity of the
character array language. Since it is an array and not a pointer, checking
for its validity is likely not correct. If you look at what is attempted
inside the test brackets you see that what is likely is that the coder is
testing to see if the string is empty.
So the test has been changed to check for emptiness of string instead of
validity of pointer.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4643>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list