[mythtv-commits] Ticket #4630: Silence ping errors

[MythTV]

#4630: Silence ping errors
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |       Owner:  ijr    
     Type:  patch                             |      Status:  new    
 Priority:  trivial                           |   Milestone:  unknown
Component:  mythtv                            |     Version:  head   
 Severity:  low                               |     Mlocked:  0      
----------------------------------------------+-----------------------------
 The attached trivial patch, mythtv-silence_ping_error.patch , silences the
 error output from ping when the installed version expects the -t argument
 to be used to specify the packet type, rather than a timeout (i.e. for
 BSD-like ping commands, such as the one distributed by GNU inetutils).
 Without the patch, the error:

 unsupported packet type: 3

 is output to the mythbackend log.  The patch simply redirects standard
 error to stdout (which had already been redirected to /dev/null).

 The code already supports a "fallback" mode, in that if the exit status of
 the command is not 0, the ping is retried without the -t argument, so this
 is simply a cosmetic fix for logging to prevent users from worrying about
 the error.  Though this fallback ping didn't report any errors on my
 system, I also redirected its stderr to stdout (which is also redirected
 to /dev/null), as the interpretation of the results of the pings is well
 enough reported by the code in mythcontext, so if errors do occur on some
 systems, users shouldn't see the ping errors themselves.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4630>
MythTV <http://svn.mythtv.org/trac>
MythTV