[mythtv-commits] Ticket #3642: "Program guide in live tv" keybinding overrides guide jump point

MythTV mythtv at cvs.mythtv.org
Sat Feb 2 06:03:21 UTC 2008


#3642: "Program guide in live tv" keybinding overrides guide jump point
-------------------------+--------------------------------------------------
 Reporter:  anonymous    |        Owner:  cpinkham
     Type:  enhancement  |       Status:  assigned
 Priority:  minor        |    Milestone:  unknown 
Component:  mythtv       |      Version:  head    
 Severity:  medium       |   Resolution:          
  Mlocked:  0            |  
-------------------------+--------------------------------------------------
Changes (by cpinkham):

  * owner:  ijr => cpinkham
  * status:  new => assigned


Comment:

 Roo, can you try the patch attached called
 'localAction_over_jumppoint_v1.diff'.  I believe it accomplishes what you
 are trying to do in a better way.

 I believe this is a more generic solution.  It was easier to code it up as
 a proof of concept than trying to explain it.  This will let you assign
 the same key to a global jumppoint and a local action.  The jumppoint is
 now registered with a 'localAction' keyword.  If the localAction of the
 jumppoint is found to be one of the actions for the key in the local
 context, then the jump point is not used.  I tested this by setting 'S' as
 the key on the 'Program Guide' jumppoint.  From the main menu or the watch
 recordings screen, the jumppoint would be processed if I hit 'S' and I
 would jump to the Program Guide.  If I was watching a recording, then
 TranslateKeyPress() would see that that the key I was using had a
 localAction defined on the jumppoint and this key was also bound to that
 local action and would use the local action instead of the jumppoint.
 This method is easier to extend to other actions, they just have to
 register the localAction keyword using REG_JUMPLOC instead of REG_JUMP.  I
 haven't made any DB modifications as part of this patch, I have those
 lines #ifdef'ed out right now in the patch.  You should still be able to
 test the patch though, because the only info that comes out of the DB is
 the keylist for the jumppoint.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3642#comment:14>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list