[mythtv-commits] Ticket #5515: pointer check before dereference in NuppelVideoPlayer.cpp and tv_play.cpp

MythTV mythtv at cvs.mythtv.org
Wed Dec 24 15:51:28 UTC 2008


#5515: pointer check before dereference in NuppelVideoPlayer.cpp and tv_play.cpp
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |        Owner:  ijr    
     Type:  defect                           |       Status:  closed 
 Priority:  trivial                          |    Milestone:  unknown
Component:  mythtv                           |      Version:  head   
 Severity:  low                              |   Resolution:  fixed  
  Mlocked:  0                                |  
---------------------------------------------+------------------------------
Changes (by danielk):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [19445]) Fixes #5515. Few more null pointer checks.

 Note: I did not apply the GuideGrid.cpp portion of the patch, those
 pointers are guarranteed to be valid. Nor did I apply the dynamic_cast<>
 for the ivtv decoder, also guarranteed. And the V4LChannel changes in
 tv_rec.cpp are also not needed, C++ inheritance takes care of dispatching
 those methods correctly for us (you only need to worry about unexpected
 virtual dispatch in dtors).

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5515#comment:2>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list