[mythtv-commits] Ticket #3966: TVRec::CheckChannelPrefix erroneously detecting channels with underscore spacer

[MythTV]

#3966: TVRec::CheckChannelPrefix erroneously detecting channels with underscore
spacer
-------------------------------------------------------+--------------------
 Reporter:  Tom Dexter <digitalaudiorock at hotmail.com>  |        Owner:  danielk
     Type:  defect                                     |       Status:  new    
 Priority:  minor                                      |    Milestone:  0.21   
Component:  mythtv                                     |      Version:  head   
 Severity:  medium                                     |   Resolution:         
  Mlocked:  0                                          |  
-------------------------------------------------------+--------------------

Comment(by Tom Dexter <digitalaudiorock at hotmail.com>):

 I think I found the problem.  The is_extra_char_useful variable is
 inadvertently getting set to true when the entire channel is keyed in.
 This is even true with DVB channels.  I have a remote button mapped to the
 '.' character, and if I actually enter the entire channel number '4.1'
 without letting the smart channel change fill in the spacer, it waits for
 the OSD timeout as well.  The problem is in this block of code:


 {{{
     // Is an extra characher useful for disambiguation?
     if (query.exec(basequery.arg(prefix)))
         is_extra_char_useful = query.next();
     for (uint i = 0; i < ((is_extra_char_useful) ? 0 : fchannum.size());
 i++)
         is_extra_char_useful = (fchannum[i] != add_spacer(prefix,
 fspacer[i]));
 }}}

 The sql query (which didn't exist in the older code) is always setting
 is_extra_char_useful to true and preventing the following for loop from
 executing.  In my case, even when prefix was 4.1 and all values in
 fchannum where set to '4.1' and all values of fspacer where "", the loop
 (which would never set is_extra_char_useful to true) was never executing.
 If I comment out the sql query everything seems to work fine.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3966#comment:16>
MythTV <http://svn.mythtv.org/trac>
MythTV