[mythtv-commits] Ticket #4215: pip colors not right after changeset 14692

[MythTV]

#4215: pip colors not right after changeset 14692
----------------------+-----------------------------------------------------
 Reporter:  skamithi  |       Owner:  skamithi
     Type:  defect    |      Status:  new     
 Priority:  minor     |   Milestone:  0.21    
Component:  mythtv    |     Version:  head    
 Severity:  medium    |     Mlocked:  0       
----------------------+-----------------------------------------------------
 spoke to danielk about the issue. PiP compositing is wrong. patch just
 exposed the bug. Working on a bug fix.

 --excerpt from daniel's email--

 ''the pip compositing, VideoOutput::ShowPip() is the problem. In
 particular, this code is completely bogus:''
 {{{
    for (int i = 0; i < piph; i++)
    {
        memcpy(frame->buf + (i + yoff) * frame->width + xoff,
               pipbuf + i * pipw, pipw);
    }

    // Copy U & V (half plane chroma values)
    xoff /= 2;
    yoff /= 2;

    unsigned char *uptr = frame->buf + frame->width * frame->height;
    unsigned char *vptr = frame->buf + frame->width * frame->height *
                          5 / 4;
    int vidw = frame->width / 2;
 }}}

 ''This should be using frame->buf, frame->pitches[], and frame->offsets[],
 and not looking at the width and height at all to set this up.''

 ''As is this code was already not working before [14692] on ATI and
 with the proprietary drivers nor with some Intel drivers, and would
 cause segfaults with VIA hardware. The problem is just more visible now''

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4215>
MythTV <http://svn.mythtv.org/trac>
MythTV