[mythtv-commits] Ticket #4115: Network Control causes segfaults

[MythTV]

#4115: Network Control causes segfaults
---------------------+------------------------------------------------------
 Reporter:  danielk  |        Owner:  danielk
     Type:  patch    |       Status:  closed 
 Priority:  minor    |    Milestone:  0.21   
Component:  mythtv   |      Version:  head   
 Severity:  medium   |   Resolution:  fixed  
  Mlocked:  0        |  
---------------------+------------------------------------------------------
Changes (by danielk):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [14921]) Fixes #4115. Backports tv_play.cpp portion of [14794] to fix
 the major cause of segfaults using network control in 0.20-fixes.

 The problem here seems to be that Network Control was never updated when
 we changed how LiveTV worked in MythTV. For keyboard input we check the
 ignoreKeys boolean and ignore unsafe actions while it is set. But Network
 Control completely ignores this and so you can do anything you want during
 the ringbuffer switching.

 Another problem is that if both keyboard control and network control are
 active two incompatible actions can be triggered in a single iteration of
 the TV main loop, this is fixed by simply skipping network control events
 if we have a keyboard event, until the next iteration of the loop.

 Finally, there were a couple thread safety issues which were trivially
 fixed.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4115#comment:9>
MythTV <http://svn.mythtv.org/trac>
MythTV