[mythtv-commits] Ticket #4132: In some menu's ESCAPE action is not handled appropriately
MythTV
mythtv at cvs.mythtv.org
Tue Nov 6 15:04:50 UTC 2007
#4132: In some menu's ESCAPE action is not handled appropriately
---------------------+------------------------------------------------------
Reporter: danielk | Owner: danielk
Type: patch | Status: new
Priority: minor | Milestone: 0.21
Component: mythtv | Version: head
Severity: medium | Resolution:
Mlocked: 0 |
---------------------+------------------------------------------------------
Comment(by paulh):
I've just given the v2 patch a quick test.
The two test cases I knew about are still broken with this patch all be it
in slightly different ways :-).
One is the search dialog in MythMusic ticket #4124. When you press escape
you are still presented with the 'Update Playlist Options' dialog when you
shouldn't. See PlaybackBoxMusic::showSearchDialog()
Also in the MythPopupBox::showGetTextPopup() dialog escape now works as
expected but the Cancel button doesn't that's because there is no SLOT
called cancel() I guess that should be reject(). I noticed this in
MythGallery when using the rename option.
Doesn't changing the return values from MythPopupBox have a lot of
potential to break things? How confident are you that you have found all
places where it could break things? Also what about all the unofficial
plugins this may break?
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4132#comment:1>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list