[mythtv-commits] Ticket #4115: Network Control causes segfaults

[MythTV]

#4115: Network Control causes segfaults
---------------------+------------------------------------------------------
 Reporter:  danielk  |        Owner:  danielk
     Type:  patch    |       Status:  new    
 Priority:  minor    |    Milestone:  0.21   
Component:  mythtv   |      Version:  head   
 Severity:  medium   |   Resolution:         
  Mlocked:  0        |  
---------------------+------------------------------------------------------

Comment(by danielk):

 (In [14794]) Refs #4115. Fixes for Network Control segfaults in trunk.

 There are two common causes of segfaults when using the telnet network
 control API:
  * The NetworkControl class itself is not thread-safe in it QString usage
  * TV Play accepts commands during LiveTV buffer switching.

 This fixes the first problem by adding a couple locking instances and
 using QDeepCopy when passing strings between threads.
 And this fixes the second problem by respecting the ignoreKeys variable,
 it by only executing network commands after the keypressed buffer is empty
 (this avoids back to back processing which doesn't give the RunTV main
 loop a chance to get into a consistent state between commands if a key and
 network command are both available in the same loop iteration.)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4115#comment:3>
MythTV <http://svn.mythtv.org/trac>
MythTV