[mythtv-commits] Ticket #1088: Convert to using MARK_GOP_BYFRAME instead of MARK_GOP_START

[MythTV]

#1088: Convert to using MARK_GOP_BYFRAME instead of MARK_GOP_START
------------------------------+---------------------------------------------
 Reporter:  adeffs at gmail.com  |        Owner:  cpinkham
     Type:  task              |       Status:  assigned
 Priority:  minor             |    Milestone:  0.21    
Component:  mythtv            |      Version:  head    
 Severity:  medium            |   Resolution:          
  Mlocked:  0                 |  
------------------------------+---------------------------------------------

Comment(by maverik044):

 Here's my go at the patch.  Patch is attached in three parts.

 1. gopbyframe.diff I've been able to test.  It works works with videos and
 recordings I have.  It works with DVD's I've tested.  It fixes the problem
 of mythcommflag generating incorrect position maps for mpeg files and
 recordings.  This fixes FFW/REW Seeking on mpeg files that have NO
 position map and that the keyframedist is not constant, but still will
 want to have a position map as the picture is blocky in FFW and REW.

 2. mpegrec_gopbyframe.diff changes the mpeg recorder to use a keyframedist
 of 1.  I have no way of testing this, this is why it is separate.  I noted
 that the other recorders seem to already use MARK_GOP_BYFRAME, so no
 changes needed.

 3. ivtv_gopbyframe.diff changes ivtvdecoder.cpp to use MARK_GOP_BYFRAME
 and keyframedist of 1 if there is no position map.  Again I have no way to
 test this, so it is also separate.

 There's some code in decoderbase.cpp in PosMapFromEnc that could be
 removed if all three diff files are used.  This is further code in
 decoderbase.cpp and avformatdecoder.cpp that is only needed to support old
 database position maps of type MARK_GOP_START.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1088#comment:8>
MythTV <http://svn.mythtv.org/trac>
MythTV