[mythtv-commits] Ticket #4398: Changeset 15257 breaks myth backend startup in some cases

MythTV mythtv at cvs.mythtv.org
Mon Dec 31 05:18:39 UTC 2007


#4398: Changeset 15257 breaks myth backend startup in some cases
----------------------------------------+-----------------------------------
 Reporter:  patrickhdonnelly at gmail.com  |        Owner:  greg    
     Type:  defect                      |       Status:  assigned
 Priority:  major                       |    Milestone:  unknown 
Component:  upnp                        |      Version:  head    
 Severity:  medium                      |   Resolution:          
  Mlocked:  0                           |  
----------------------------------------+-----------------------------------

Comment(by greg):

 >
 > Tracking down when the table was created, I found in the same commit a
 function that populates upnpmedia recursively from the directory set at
 'VideoStartupDir' in the settings table; for whatever reason (this has
 always been a backend-only box so maybe it just never got set?), this was
 missing for this host; as a result it

  If you run MythVideo on any box, be it frontend/backend the value will be
 populated. It's also a Global value so it's expected to be the same on all
 systems.  I thought I had added code to check to make sure we got a
 response back before doing the scan though. Gonna change that in a sec.



 >had a symlink pointing from a child directory to a parent, resulting in
 an infinite >loop, a hung mythbackend, and a shit-load of binlog files on
 my mysql server.
 >
 >
 > a) UPnpCDSVideo::buildFileList needs some sanity checking; it should
 error out or just exit cleanly if VideoStartupDir doesn't exist in the
 settings db

  That's done now.

 > b) buildFileList absolutely needs to make sure it isn't indexing the
 same directory more than once

  There is nothing in any of the other recursive directory scanning code
 that checks for a user causing a symlink look(unless it's all be changed
 since last I looked at it). So if something is gonna be changed it should
 be done in MythVideo, MythGame and MythMusic as well.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4398#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list