[mythtv-commits] Ticket #3885: mytharchive: can not deselect selected files

MythTV mythtv at cvs.mythtv.org
Sun Aug 26 16:30:57 UTC 2007


#3885: mytharchive: can not deselect selected files
----------------------------------------------+-----------------------------
 Reporter:  Russell Mora <rd.mora at gmail.com>  |       Owner:  paulh  
     Type:  defect                            |      Status:  new    
 Priority:  trivial                           |   Milestone:  unknown
Component:  mytharchive                       |     Version:  head   
 Severity:  low                               |     Mlocked:  0      
----------------------------------------------+-----------------------------
 The mytharchive video and recording file selector each individually
 enforce a "one file must be selected rule".  The causes problems if I,
 say, select some video and recording files for archive but then decide I
 don't want to archive the video files.  I will still be archiving some
 files (the recordings) however the UI does not let me deselect all the
 video files.

 This patch removes this restriction from the video and recordings
 selectors.  This is safe because the parent screen separately enforces the
 "one file must be selected rule".

 {{{
 Index: mytharchive/mytharchive/videoselector.cpp
 ===================================================================
 --- mytharchive/mytharchive/videoselector.cpp   (revision 14309)
 +++ mytharchive/mytharchive/videoselector.cpp   (working copy)
 @@ -317,13 +317,6 @@

  void VideoSelector::OKPressed()
  {
 -    if (selectedList.count() == 0)
 -    {
 -        MythPopupBox::showOkPopup(gContext->GetMainWindow(), tr("Myth
 Archive"),
 -            tr("You need to select at least one video file!"));
 -        return;
 -    }
 -
      // remove all videos from archivelist
      MSqlQuery query(MSqlQuery::InitCon());
      query.prepare("DELETE FROM archiveitems WHERE type = 'Video'");
 Index: mytharchive/mytharchive/recordingselector.cpp
 ===================================================================
 --- mytharchive/mytharchive/recordingselector.cpp       (revision 14309)
 +++ mytharchive/mytharchive/recordingselector.cpp       (working copy)
 @@ -312,13 +312,6 @@

  void RecordingSelector::OKPressed()
  {
 -    if (selectedList.count() == 0)
 -    {
 -        MythPopupBox::showOkPopup(gContext->GetMainWindow(), tr("Myth
 Archive"),
 -                                  tr("You need to select at least one
 recording!"));
 -        return;
 -    }
 -
      // remove all recordings from archivelist
      MSqlQuery query(MSqlQuery::InitCon());
      query.prepare("DELETE FROM archiveitems WHERE type = 'Recording'");
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3885>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list