[mythtv-commits] Ticket #3884: mytharchive: aspect ratio of titles controlled by chapter menu aspect ratio

[MythTV]

#3884: mytharchive: aspect ratio of titles controlled by chapter menu aspect ratio
----------------------------------------------+-----------------------------
 Reporter:  Russell Mora <rd.mora at gmail.com>  |       Owner:  paulh  
     Type:  defect                            |      Status:  new    
 Priority:  minor                             |   Milestone:  unknown
Component:  mytharchive                       |     Version:  head   
 Severity:  low                               |     Mlocked:  0      
----------------------------------------------+-----------------------------
 Currently the aspect ratio that mytharchive uses for titles is the same as
 the chaptermenuAspectRatio setting, if set.  This does not make sense to
 me, for example says I want the chapter menus in 4:3 (because my broken
 DVD player always screws up 16:9 menus) this means that the title is
 specified as 4:3 as well even if it is 16:9.  As such I have just removed
 the checking of chaptermenuAspectRatio from my version of the script - it
 just checks the title's actual aspect ratio instead.  To me this seems
 like the right thing to do, so I thought I better submit it for your
 consideration.

 Here is the patch - it looks more confusing that it is due to the
 indentation changes.  It just removes the check of chaptermenuAspectRatio:

 Index: mytharchive/mythburn/scripts/mythburn.py
 ===================================================================
 --- mytharchive/mythburn/scripts/mythburn.py    (revision 14309)
 +++ mytharchive/mythburn/scripts/mythburn.py    (working copy)
 @@ -2473,19 +2473,12 @@
              video = dvddom.createElement("video")
              video.setAttribute("format",videomode)

 -            # set the right aspect ratio
 -            if chaptermenuAspectRatio == "4:3":
 -                video.setAttribute("aspect", "4:3")
 -            elif chaptermenuAspectRatio == "16:9":
 +            # ALWAYS use same aspect ratio as the video
 +            if getAspectRatioOfVideo(itemnum) > aspectRatioThreshold:
                  video.setAttribute("aspect", "16:9")
                  video.setAttribute("widescreen", "nopanscan")
 -            else:
 -                # use same aspect ratio as the video
 -                if getAspectRatioOfVideo(itemnum) > aspectRatioThreshold:
 -                    video.setAttribute("aspect", "16:9")
 -                    video.setAttribute("widescreen", "nopanscan")
 -                else:
 -                    video.setAttribute("aspect", "4:3")
 +            else:
 +                video.setAttribute("aspect", "4:3")

              menus.appendChild(video)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3884>
MythTV <http://svn.mythtv.org/trac>
MythTV