[mythtv-commits] Ticket #2096: Mac OS X Plextor ConvertX USB Video Capture support

[MythTV]

#2096: Mac OS X Plextor ConvertX USB Video Capture support
-----------------------------+----------------------------------------------
 Reporter:  awk at awkward.org  |        Owner:  ijr     
     Type:  patch            |       Status:  reopened
 Priority:  minor            |    Milestone:          
Component:  mythtv           |      Version:          
 Severity:  medium           |   Resolution:          
-----------------------------+----------------------------------------------
Comment (by ijr):

 Did a quick once-over of the patch:
  * I'm not very comfortable with the amount of ifdefs in there.  Some
 refactoring into other classes would probably be significantly cleaner.
  * I'm even more unsure about including the driver & firmware in the
 mythtv source/build process.  Seems rather odd to me.
  * Please don't make tarballs that extract into the current directory.
  * svn diff will create diffs for all changed files, you don't have to
 make separate patches for each file.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2096#comment:5>
MythTV <http://www.mythtv.org/>
MythTV