[mythtv-commits] mythtv commit: r11619 - in trunk/mythtv by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2006-10-26 13:54:23 +0000 (Thu, 26 Oct 2006)
New Revision: 11619
   Changeset: http://cvs.mythtv.org/trac/changeset/11619

Added:

   trunk/mythtv/libs/libmythtv/programdata.cpp
   trunk/mythtv/libs/libmythtv/programdata.h
   trunk/mythtv/programs/mythfilldatabase/channeldata.cpp
   trunk/mythtv/programs/mythfilldatabase/channeldata.h
   trunk/mythtv/programs/mythfilldatabase/filldata.h
   trunk/mythtv/programs/mythfilldatabase/fillutil.cpp
   trunk/mythtv/programs/mythfilldatabase/fillutil.h
   trunk/mythtv/programs/mythfilldatabase/icondata.cpp
   trunk/mythtv/programs/mythfilldatabase/icondata.h
   trunk/mythtv/programs/mythfilldatabase/main.cpp
   trunk/mythtv/programs/mythfilldatabase/xmltvparser.cpp
   trunk/mythtv/programs/mythfilldatabase/xmltvparser.h

Modified:

   trunk/mythtv/libs/libmythtv/datadirect.cpp
   trunk/mythtv/libs/libmythtv/datadirect.h
   trunk/mythtv/libs/libmythtv/libmythtv.pro
   trunk/mythtv/programs/mythfilldatabase/filldata.cpp
   trunk/mythtv/programs/mythfilldatabase/mythfilldatabase.pro

Log:

Refs #1770. Splits filldata.cpp functions into functional classes.

This looks like a big change, but in fact none of the code had been changed except to move functions and variables to classes (or main).

The Data Direct program insertion function was moved to DataDirectProcessor, the other program data insertion and deletion functions were moved to ProgramData. The xmltv parsing functions were moved to the XMLTVParser class, the channel data update/delete/insert functions were moved to ChannelData, the icon data update/insert functions were moved to IconData, and the overall logic was moved to FillData, while main() was moved to main.cpp and still does the command line parsing and manipulates the classes.

To make the EIT data insertion compatible with XMLTV/DataDirect data I need the program data insertion classes to be accessible to the EIT processor in libmythtv. So the main reason for the splitting is to move the program data insertion methods to libmythtv. At some point in the future it might be useful to have access to the other portions of fill data for the frontend channel editor, but for now I've left the code in mythfilldatabase.

I've tested this with DataDirect and two XMLTV data grabbers. Although since very little code has changed it is more likely that there might be header problems.