[mythtv-commits] Ticket #1586: LCD::Get() creates LCD object, even when disabled

[MythTV]

#1586: LCD::Get() creates LCD object, even when disabled
----------------------------------+-----------------------------------------
 Reporter:  perveilerj at yahoo.com  |        Owner:  ijr    
     Type:  patch                 |       Status:  closed 
 Priority:  minor                 |    Milestone:         
Component:  mythtv                |      Version:         
 Severity:  medium                |   Resolution:  invalid
----------------------------------+-----------------------------------------
Comment (by perveilerj at yahoo.com):

 I admittedly don't know much about the LCD code, but it was my impression
 that to use the LCD class you had to first call LCD::Setup() (at least
 this is what mythfrontend does in main() ).  In the patch m_enabled is set
 in LCD::Setup():

 {{{
 m_enabled  = gContext->GetNumSetting("LCDEnable", 0) != 0;
 }}}

 I also set m_enabled in LCD::connectToHost():

 {{{
 m_enabled  = gContext->GetNumSetting("LCDEnable", 0) != 0;
 }}}

 If calling LCD::Setup() isn't a requirement I'd think that calling
 LCD::connectToHost() would be and then m_enabled would be set there.

 Or maybe I'm missing something entirely more obvious?  Sorry if that's the
 case...

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/1586>
MythTV <http://www.mythtv.org/>
MythTV