[mythtv-commits] Ticket #713: Per-channel offset for DataDirect listings
MythTV
mythtv at cvs.mythtv.org
Mon Mar 6 06:23:04 UTC 2006
#713: Per-channel offset for DataDirect listings
-------------------------------------------+--------------------------------
Reporter: Joe Votour <joevph at yahoo.com> | Owner: cpinkham
Type: patch | Status: assigned
Priority: minor | Milestone: 0.20
Component: mythtv | Version: head
Severity: low | Resolution:
-------------------------------------------+--------------------------------
Comment (by cpinkham):
I merged this into my tree, made a few tweaks, and then realized that it
is missing a couple major pieces. The attached patch does not handle
keeping the various program* tables such as programrating in sync with the
adjusted times that are inserted. You also are not using the tmoffset
amount when the data is cleared from the database, meaning that at the end
of the day, you could be clearing data for a 24-hour period that is on an
even day boundary, but when you reinsert data, it may not start/end on
that 24-hour boundary because of the tmoffset, so you could have
incomplete data around midnight. In order for this to be committed to
SVN, you need to handle the tmoffset on the various program* table inserts
as well as the deletes that are in clearDataByChannel() in filldata.cpp.
I also don't think that we need the precision down to one second on the
tmoffset value, so I changed this to 1 minute and use a spinbox instead of
a lineedit in order to do validity checking on the tmoffset value. I also
had to change your insert statement to not use a sub-select, but to
instead join against the channel table. I think the sub-select fails on
older MySQL revisions which we are still trying to support. If you want
to correct the insert/delete issues above and resubmit, then I'll take
another look. Also, to save time, if you want to start with my merged
copy of the source, that will help get this committed quicker since I
won't have to correct the issues I describe above that I fixed while
merging into my copy of SVN. I'll attach the merged patch from my tree so
you'll have that to work with. If I have to remake the second -> minute
and sub-select changes in order to merge this in again, it will take
longer for me to get it into SVN unfortunately.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/713>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list