[mythtv-commits] Ticket #1430: compile warnings in eitfixup.cpp - patch included

[MythTV]

#1430: compile warnings in eitfixup.cpp - patch included
----------------------------------------+-----------------------------------
 Reporter:  David Buzz <buzz at oska.com>  |       Owner:  ijr
     Type:  defect                      |      Status:  new
 Priority:  minor                       |   Milestone:     
Component:  mythtv                      |     Version:     
 Severity:  medium                      |  
----------------------------------------+-----------------------------------
 Just a trivial patch to eitfixup.cpp, I'm no master coder, but it looks
 like someone has used a '!=' when meaning to use a '= !'.   Patch below
 fixes the compile warning (gcc 4.0.1/fedora), but I'm not sure if I've
 screwed the logic up or anything.


 {{{
 Index: eitfixup.cpp
 ===================================================================
 --- eitfixup.cpp        (revision 9234)
 +++ eitfixup.cpp        (working copy)
 @@ -290,13 +290,13 @@
          // the description as we might destroy other useful information
          captures = tmpUKCC.capturedTexts();
          for (it = captures.begin(); it != captures.end(); ++it)
 -            event.SubTitled != (*it == "S");
 +            event.SubTitled = !(*it == "S");
      }
      else if ((position = tmpUKCC.search(event.Event_Subtitle)) != -1)
      {
          captures = tmpUKCC.capturedTexts();
          for (it = captures.begin(); it != captures.end(); ++it)
 -            event.SubTitled != (*it == "S");
 +            event.SubTitled = !(*it == "S");

          // We remove [AD,S] from the subtitle.
          QString stmp = event.Event_Subtitle;
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1430>
MythTV <http://www.mythtv.org/>
MythTV