[mythtv-commits] Ticket #1945: DVB-S/diseqc patch

[MythTV]

#1945: DVB-S/diseqc patch
--------------------------------+-------------------------------------------
 Reporter:  yeasah at schwide.net  |        Owner:  danielk
     Type:  enhancement         |       Status:  new    
 Priority:  minor               |    Milestone:  0.20   
Component:  mythtv              |      Version:  head   
 Severity:  medium              |   Resolution:         
--------------------------------+-------------------------------------------
Comment (by yeasah at schwide.net):

 I had a chance to try out the branch (with the two fixes I mentioned
 before to the changes that were made on import), and there are other
 problems that have been added to the diseqc code itself. It doesn't see
 and doesn't let you add switch children, for example.

 It probably would have been pretty easy to find the problems if the code
 hadn't had so many syntax and other non-functional changes along with some
 real functionality changes -- it makes it really hard to see the few
 places you changed the code materially when so much of the code has been
 touched. It would have been much better to have the initial import be
 applied without any functionality changes (just renames and simple
 transformations like that), so that we had baseline working functionality,
 and then functional changes applied on top (in another changeset) so they
 could be easily recognized and considered.

 Or just follow another common approach to open source patch contribution
 -- ask the original author to make any changes. That way you avoid
 breaking stuff because you might not fully understand the code, and the
 amount of time you spend handling externally sourced code goes down.

 Anyway -- I wouldn't mind tracking down the new problems, but I would need
 to see the functional changes as a separate changeset from the non-
 functional changes, so that I can actually see something useful in terms
 of what is different from my original code.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1945>
MythTV <http://www.mythtv.org/>
MythTV