[mythtv-commits] Ticket #1114: mythrename.pl - call finish on statement before disconnecting

[MythTV]

#1114: mythrename.pl - call finish on statement before disconnecting
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |       Owner:  xris
     Type:  patch                             |      Status:  new 
 Priority:  trivial                           |   Milestone:      
Component:  mythtv                            |     Version:      
 Severity:  low                               |  
----------------------------------------------+-----------------------------
 The attached patch ensures that statement handles are not active before
 disconnecting to avoid DBI's printing a warning.  Without the patch, when
 the script fails, the user sees the mythrename.pl-generated error and a
 DBI warning

 {{{
 mkdir view/Lost: Permission denied at ./mythrename.pl line 400
 DBI::db=HASH(0x8356598)->disconnect invalidates 1 active statement handle
 (either destroy statement handles or call finish on them before
 disconnecting)
 at ./mythrename.pl line 227.
 }}}

 The warning is meant to alert the user that a fetch loop terminated early,
 perhaps due to an uncaught error.  However, since mythrename.pl has proper
 error checking (or, at least no known uncaught errors), the warning is
 likely to confuse the user in spite of the descriptive error message.  (I
 tested the failure mode by generating links to a directory on which I
 remove write access.)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1114>
MythTV <http://www.mythtv.org/>
MythTV