[mythtv-commits] mythtv commit: r8717 by danielk

mythtv@cvs.mythtv.org mythtv at cvs.mythtv.org
Wed Jan 25 14:51:24 UTC 2006


      Author: danielk
        Date: 2006-01-25 14:51:23 +0000 (Wed, 25 Jan 2006)
New Revision: 8717
   Changeset: http://cvs.mythtv.org/trac/changeset/8717

Modified:

   trunk/mythtv/libs/libmythtv/previewgenerator.cpp
   trunk/mythtv/libs/libmythtv/previewgenerator.h

Log:

Fixes #1078. References #956.

The fix for #956 made the invalid assumption that shutting down the
~PlaybackBox() should never take longer than 500 ms to finish. 
This was a zombie prevention measure. I've removed the timeout,
and I've also implemented a deleteLater() function which cleans
up some things early, and should give us snappier preview response.

Torbjorn, can you run with '-v playback' for a while, and then
grep for "previewThreadDone took" in the logs, I'd like some info
on how long this takes in the longest case on your system. On
my system it never takes longer than 7 ms, which is why I thought
a 500 ms timeout would be safe. Maybe I can use a 5 minute 
timeout or something like that..






More information about the mythtv-commits mailing list