[mythtv-commits] Ticket #962: SEGV: RemoteGetConflictList returns NULL but the caller expects empty vector

MythTV mythtv at cvs.mythtv.org
Sun Jan 8 01:54:08 UTC 2006


#962: SEGV: RemoteGetConflictList returns NULL but the caller expects empty
vector
---------------------------------------------------------+------------------
 Reporter:  bolek-mythtv at curl.com (Boleslaw Ciesielski)  |       Owner:  ijr 
     Type:  patch                                        |      Status:  new 
 Priority:  minor                                        |   Milestone:      
Component:  mythtv                                       |     Version:  head
 Severity:  medium                                       |  
---------------------------------------------------------+------------------
 In case there aren't any conflicts, RemoteGetConflictList returns NULL.
 But the only call in ProgramInfo::ShowNotRecordingDialog is expecting an
 empty vector instead. This is causing a SEGV in mythfrontend.

 The attached patch against 8517 fixes the problem by always returning a
 non-null vector. The alternative would be to add a null check at the call
 site, but there is no benefit in doing this since the vector is allocated
 anyway (before it is known that it is empty).

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/962>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list