[mythtv-commits] Re: Ticket #935: Preview Thumbnail regenerated unnecessarily

[MythTV]

#935: Preview Thumbnail regenerated unnecessarily
------------------------------+---------------------------------------------
 Reporter:  stutty at gmail.com  |        Owner:  ijr 
     Type:  defect            |       Status:  new 
 Priority:  minor             |    Milestone:  0.19
Component:  mythtv            |      Version:  head
 Severity:  low               |   Resolution:      
------------------------------+---------------------------------------------
Comment (by cpinkham):

 Can you see if you can accomplish the same thing by editting
 PlaybackBox::play() and moving the following line down from the middle of
 the method to the end right before the return line?

 state = kStarting; // restart playback preview

 Put that line right before this line at the end:

 return playCompleted;

 I think that will cause the preview to not be updated until we've
 refreshed the recordings list which till take into account the fact that
 we just deleted the recording we were watching.  The frontend is hanging
 because the preview generation is consuming the backend CPU at the same
 time we're trying to refill the recordings list.  This will delay any
 preview generation or playback until after we've refilled the list.
 PreviewFromBookmark isn't the only reason we might be updating the pixmap
 here, it could be that the recording length has changed or the cutlist was
 changed, etc.. so I think it might be better to use this delayed start
 rather than not updating the pixmap at all.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/935>
MythTV <http://www.mythtv.org/>
MythTV