[mythtv-commits] mythtv commit: r8803 by danielk

mythtv@cvs.mythtv.org mythtv at cvs.mythtv.org
Wed Feb 1 00:07:41 UTC 2006


      Author: danielk
        Date: 2006-02-01 00:07:40 +0000 (Wed, 01 Feb 2006)
New Revision: 8803
   Changeset: http://cvs.mythtv.org/trac/changeset/8803

Modified:

   trunk/mythtv/programs/mythfrontend/playbackbox.cpp
   trunk/mythtv/programs/mythfrontend/playbackbox.h

Log:

A few things to try to prevent badness in PlaybackBox

 * Delete freeSpaceTimer.. Also disconnect all the timers before deleting them.
 * Add a lock to killPlayer itself, in addition to killPlayerSafe lock.
 * check killPlayer return value when killing it for a menu, this
   is needed in case a menu is started but the player has only just
   started. Also use the killPlayerSafe lock so that a concurrent
   call to killPlayerSafe() doesn't cause problems.
 * Fix potential crash when reading in a broken XML UI file.
 * get an application lock before checking if a recently updated
   preview matches the currently desired preview; this shouldn't
   have caused any serious problem, but if you were unlucky
   the pixmap update could have been delayed.
 * repaint the background when you get a new pixmap, in case
   the video playback stopped and the preview image has a different
   aspect ratio; without this the video preview can show through.

The first three items hopefully address the hangs on quick exits from the PlaybackBox, while the others were fixes for problems I saw reading through the code for problems.






More information about the mythtv-commits mailing list